Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Form]Form item help reverse offset is a break change #4641

Closed
YSMJ1994 opened this issue Dec 7, 2023 · 0 comments · Fixed by #4645
Closed

[Form]Form item help reverse offset is a break change #4641

YSMJ1994 opened this issue Dec 7, 2023 · 0 comments · Fixed by #4645
Assignees
@YSMJ1994
Labels
🐞 Bug Something isn't working Next release issues to close in next release

Comments

@YSMJ1994
Copy link
Contributor

YSMJ1994 commented Dec 7, 2023

Component

Form

Steps to reproduce

#3994 改动是一个break chagne，help 是一个用户可以配置的参数，默认添加-marginTop会破坏现有的样式，需要调整为一个通过props开启的功能，且默认值应为false，保持原有layout布局
@YSMJ1994 YSMJ1994 added the Next release issues to close in next release label Dec 7, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in DAILY WORK Dec 7, 2023
@YSMJ1994 YSMJ1994 added the 🐞 Bug Something isn't working label Dec 7, 2023
@YSMJ1994 YSMJ1994 self-assigned this Dec 7, 2023
@YSMJ1994 YSMJ1994 moved this from 🆕 New to 🔖 Ready in DAILY WORK Dec 7, 2023
YSMJ1994 added a commit that referenced this issue Dec 12, 2023
@YSMJ1994
feat(Form): support useMarginToDisplayHelp to control help reverse of…
e67fd2d 
…fset, close #4641
@YSMJ1994 YSMJ1994 linked a pull request Dec 12, 2023 that will close this issue
feat(Form): support preferMarginToDisplayHelp, close #4641 #4645
Merged
@YSMJ1994 YSMJ1994 moved this from 🔖 Ready to 👀 In review in DAILY WORK Dec 12, 2023
YSMJ1994 added a commit that referenced this issue Dec 13, 2023
@YSMJ1994
feat(Form): support preferMarginToDisplayHelp, close #4641 (#4645)
5e7d9d3 
* feat(Form): support preferMarginToDisplayHelp to control help reverse offset, close #4641

* fix(Form): toggle token at different size

* chore(Form): lint tsdoc for preferMarginToDisplayHelp
@github-project-automation github-project-automation bot moved this from 👀 In review to Ready to release in DAILY WORK Dec 13, 2023
@YSMJ1994 YSMJ1994 moved this from Ready to release to ✅ Done in DAILY WORK Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@YSMJ1994 YSMJ1994

Labels
🐞 Bug Something isn't working Next release issues to close in next release
Projects
DAILY WORK
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(Form): support preferMarginToDisplayHelp, close #4641 alibaba-fusion/next
1 participant
@YSMJ1994