chore: improve by codereview

cypress/support/component.ts

@@ -1,5 +1,6 @@
+/// <reference types="cypress" />
+
 import { mount } from 'cypress/react';
-import './commands';
 
 declare global {
     // eslint-disable-next-line @typescript-eslint/no-namespace

package.json

@@ -42,7 +42,7 @@
     "component"
   ],
   "dependencies": {
-    "@alifd/validate": "^2.0.1",
+    "@alifd/validate": "^2.0.2",
     "tslib": "^2.6.2"
   },
   "devDependencies": {

src/index.ts

@@ -1,6 +1,5 @@
-import { Component, MutableRefObject } from 'react';
-import Validate from '@alifd/validate';
-import { NormalizedValidateError } from '@alifd/validate/lib/types';
+import type { Component, MutableRefObject } from 'react';
+import Validate, { type NormalizedValidateError } from '@alifd/validate';
 import {
     getValueFromEvent,
     getErrorStrs,
@@ -14,7 +13,7 @@ import {
     cloneToRuleArr,
     isOverwritten,
 } from './utils';
-import {
+import type {
     FieldOption,
     ComponentInstance,
     GetUseFieldOption,
@@ -59,7 +58,6 @@ class Field {
         };
     }
 
-    private com: ComponentInstance;
     private fieldsMeta: Record<string, FieldMeta>;
     private cachedBind: Record<string, Record<string, unknown>>;
     private instance: Record<string, unknown>;
@@ -69,6 +67,7 @@ class Field {
     private values: FieldValues;
     private processErrorMessage?: FieldOption['processErrorMessage'];
     private afterValidateRerender?: FieldOption['afterValidateRerender'];
+    com: ComponentInstance;
     options: NormalizedFieldOption;
 
     constructor(com: ComponentInstance, options: FieldOption = {}) {
@@ -259,8 +258,8 @@ class Field {
             id: id || name,
             ref: this._getCacheBind(name, `${name}__ref`, this._saveRef),
             [valueName]: setValueFormatter
-                ? setValueFormatter(field.value as any, field.inputValues)
-                : (field.value as any),
+                ? setValueFormatter(field.value as ValueType, field.inputValues)
+                : field.value,
         };
 
         let rulesMap: Record<string, Omit<Rule, 'trigger'>[]> = {};
@@ -1095,7 +1094,10 @@ class Field {
         cache[action] = hander;
     }
 
-    private _getCache<R = unknown>(name: string, action: string): R | undefined {
+    /**
+     * FIXME 有一些地方用到了这些内部函数 (如 deep)，先不声明为 private
+     */
+    _getCache<R = unknown>(name: string, action: string): R | undefined {
         const cache = this.cachedBind[name] || {};
         return cache[action] as R | undefined;
     }

src/types.ts

@@ -1,4 +1,4 @@
-import type { MessagesConfig, PresetFormatter, Validator } from '@alifd/validate/lib/types';
+import type { MessagesConfig, PresetFormatter, Validator } from '@alifd/validate';
 import type { Component, useState, useMemo, Dispatch, SetStateAction, Ref, RefCallback } from 'react';
 
 export { Validator };