Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add library config #38

Merged
merged 1 commit into from
Aug 15, 2019
Merged

add library config #38

merged 1 commit into from
Aug 15, 2019

Conversation

skoppe
Copy link
Contributor

@skoppe skoppe commented Aug 14, 2019

Right now having optional as a dub dependency causes it to build the unittest configuration.

This is because the unittest config is the first in the dub.json, and when you don't specify a configuration for a dependency dub just picks the first.

If I change my compiler's configuration file (dmd.conf or ldc2.conf) and add -betterC (because I want to enforce betterC on my dependencies), the build fails because the ./tests contains files which are not betterC compatible.

By adding this library configuration the ./tests files are no longer included in the compile.

@aliak00
Copy link
Owner

aliak00 commented Aug 15, 2019

Awesome! Thanks for this. Question: There's a dependency on silly that you've left in. Will that cause other projects to get silly as well if built as a library? Maybe remove that then?

@skoppe
Copy link
Contributor Author

skoppe commented Aug 15, 2019

You are right. I removed it.

@aliak00 aliak00 merged commit 6c9aed5 into aliak00:master Aug 15, 2019
@skoppe skoppe deleted the lib-config branch November 18, 2019 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants