-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: ruff improvements #359
Conversation
Closes #356 |
@robdmoore, in updating our templates, we got a warning regarding the ruff format:
reviewing this with @neilcampbell, we realized that ruff is in a beta version but production ready state. Given this uncertainty, it seems better to continue using the Black formatter for now and hold off on integrating ruff into our templates until it reaches a more stable release phase. |
Just to add a bit more context to the above, we are planning to switch to Ruff for formatting in the repos we control and can easily handle any breaking changes in. We will however hold off on updating the templates until there is a stable release of the Ruff formatter, as to minimise any potential impact to developer projects created from the templates. |
Yep, that's a good plan - that's what I thought we'd be doing :) |
@@ -3,7 +3,8 @@ | |||
"editor.formatOnSave": true, | |||
"editor.codeActionsOnSave": { | |||
// Don't want to use isort because it conflicts with Ruff - see run on save below | |||
"source.organizeImports": false | |||
"source.organizeImports": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can probably remove the comment now.
Fixes #
Proposed Changes