Refined ABI type-check on assignment #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonpaulos
reviewed
Sep 30, 2022
ahangsu
force-pushed
the
refined-abi-assignment-type-check
branch
2 times, most recently
from
e9135d5
to
99c5c8e
Compare
ahangsu
force-pushed
the
refined-abi-assignment-type-check
branch
from
99c5c8e
to
116a88f
Compare
ahangsu
force-pushed
the
refined-abi-assignment-type-check
branch
from
a535375
to
b7354f9
Compare
* Add illustrative testing DSL for type_spec_is_assignable_to * Use NamedTuple to construct `dataclass`-alike class * Boundary testcase group guarding Co-authored-by: Hang Su <[email protected]>
ahangsu
force-pushed
the
refined-abi-assignment-type-check
branch
from
c23f1ba
to
4b07317
Compare
jasonpaulos
reviewed
Oct 13, 2022
jasonpaulos
reviewed
Oct 13, 2022
jasonpaulos
reviewed
Oct 13, 2022
|
I have one final reservation. Right now class Point(abi.NamedTuple):
x: abi.Field[abi.Uint64]
y: abi.Field[abi.Uint64]
class AccountRecord(abi.NamedTuple):
algoBalance: abi.Field[abi.Uint64]
assetBalance: abi.Field[abi.Uint64]
p = Point()
ar = AccountRecord()
assert p.type_spec() == ar.type_spec()
assert abi.type_spec_is_assignable_to(p.type_spec(), ar.type_spec())I'd argue having the equals method return true between different |
|
oh boy 🤦 just pushed to save the |
Co-authored-by: Michael Diamant <[email protected]>
michaeldiamant
approved these changes
Oct 13, 2022
There was a problem hiding this comment.
@ahangsu Looks correct - thanks for addressing the added feedback.
Consider these approval notes:
- I optionally suggest holding for a 2nd approval.
- Once this PR is merged, I expect Relax the type checking on arguments to subroutine #531 will be updated to leverage
type_spec_is_assignable_toprior to issuing a PyTeal release.
jasonpaulos
reviewed
Oct 13, 2022
ahangsu
changed the base branch from
master
to
feature/abi-assignment-type-check
ahangsu
changed the base branch from
feature/abi-assignment-type-check
to
master
|
I just dump everything to master, and get #531 merged ASAP. |
jasonpaulos
approved these changes
Oct 13, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a few short discussions with @jasonpaulos on 2022/09/21-2022/09/22, we decided to introduce another typecheck mechanism on variable assignment for ABI values.
Such mechanism would benefit following issues and PRs: #530, #531, #537