Refactor unit tests into separate files #350
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -114,7 +114,7 @@ venv.bak/ | |||
|
|
|||
There was a problem hiding this comment.
@algochoi Unrelated to the line, but opening a thread to minimize Conversation chatter:
- Thanks for taking the exercise of splitting out tests from a single file.
- Open to discussion - What are your thoughts?
- I think the chance for error will be higher by refactoring in the (long-lived) feature branch rather than
develop. - My 2c is to make the change against
developand once approved, then bring the change into the feature branch. Using the feature branch requires us to repeat the refactoring for any test changed indevelop.
- I think the chance for error will be higher by refactoring in the (long-lived) feature branch rather than
There was a problem hiding this comment.
Merging to develop sounds fine to me. I'm hoping that the merge-back process will be smooth for other PRs touching the test files as well.
There was a problem hiding this comment.
Opening up #351 to PR against develop. There are two fewer test classes in that PR compared to this one.
Refactoring Revert and refactor unit tests Finish moving tests to separate modules Remove test feature files adding method to ABIResult (#342) * adding method to ABIResult Add method to get Method by name (#345) * adding util method to get a Method from an interface or contract by name string Change paths for tests Change makefile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR separates the different unit test classes into different files for improved readability.
This PR also proposes to rename the
testdirectory totestsdirectory to prevent any conflicts with the existing Pythontestpackage.Currently merging into
feature/box-storagein fear of merge conflicts.