Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.0.0: Add ability to pass through fetch options #883

Merged
merged 4 commits into from
Aug 16, 2024

Conversation

jasonpaulos
Copy link
Contributor

When making requests, exposes an additional options object that can be passed through to the underlying BaseHTTPClient. For the default URLTokenBaseHTTPClient, this is treated as additional options to pass to the fetch network call.

Fixes #858

Base automatically changed from rest-untyped-responses-fix to 3.0.0 August 15, 2024 14:02
Copy link
Contributor

@algorandskiy algorandskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks right to me but was it tested somehow?

@jasonpaulos
Copy link
Contributor Author

Good point. I tested locally but it's always better to have a unit test. Added in 28ad187

@jasonpaulos jasonpaulos merged commit 785a441 into 3.0.0 Aug 16, 2024
2 checks passed
@jasonpaulos jasonpaulos deleted the pass-through-fetch-options branch August 16, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants