Final TypeScript changes #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove deprecated ESLint setting * Specify `SuggestedParams` type for the SuggestedParams client request * Fix default generic types of the `JSONRequest` class * Provide better return type for the `assignGroupID` method * Export `Account` type
jdtzmn
force-pushed
the
jacob/typescript-final-changes
branch
from
c46ac77
to
86e372d
Compare
… a protocol to `HTTPClient`
jdtzmn
force-pushed
the
jacob/typescript-final-changes
branch
from
86e372d
to
5d0e06c
Compare
jasonpaulos
reviewed
Apr 7, 2021
* Make `makeKeyRegistrationWithSuggestedParamsFromObject` function overloads stricter
jdtzmn
force-pushed
the
jacob/typescript-final-changes
branch
from
1b91d9d
to
dea9ba5
Compare
jasonpaulos
approved these changes
Apr 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove deprecated ESLint setting
Specify
SuggestedParamstype for the SuggestedParams client requestFix default generic types of the
JSONRequestclassProvide better return type for the
assignGroupIDmethodExport
AccounttypeCloses #336.