Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update examples to V2 #289

Merged
merged 26 commits into from
Mar 8, 2021
Merged

Update examples to V2 #289

merged 26 commits into from
Mar 8, 2021

Conversation

jdtzmn
Copy link
Contributor

@jdtzmn jdtzmn commented Mar 4, 2021

This PR fixes issues with the existing web app and adds a standard set of example scripts to the examples directory.

Fixes #254.

jdtzmn added 21 commits March 3, 2021 14:12
* Add instructions for configuring environment variables

* Include helper for generating sender/receiver pairs
* Abstract away the reading and validation of basic configuration information from environment variables into a utility function

* Include receiver mnemonic when generating sender and receiver accounts

* Update note field example to use receiver mnemonic instead of receiver address
* Improve comments in transaction group example and note field example
* Move console formatting codes from sender receiver generation example to example utils

* Add trace to error when bad arguments inputted to the `waitForConfirmation` function
* Fix webapp account address input length issue

* Fix script path in webapp

* Upgrade web app to use Algodv2 client
@CLAassistant
Copy link

CLAassistant commented Mar 4, 2021

CLA assistant check
All committers have signed the CLA.

@jdtzmn jdtzmn requested a review from jasonpaulos March 4, 2021 22:08
Copy link
Contributor

@jasonpaulos jasonpaulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a much-needed improvement! I've left a few small comments, but besides those everything looks good.

examples/app_transaction_examples.js Show resolved Hide resolved
examples/asset_create_example.js Outdated Show resolved Hide resolved
examples/log_sig_example.js Outdated Show resolved Hide resolved
examples/app_transaction_examples.js Show resolved Hide resolved
* Use Uint8Array for metadata instead of string

* Include decimals parameter

* Rename misspelled transaction parameters
@jdtzmn jdtzmn merged commit d322bab into develop Mar 8, 2021
@jdtzmn jdtzmn deleted the jacob/v2-examples branch March 8, 2021 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Examples needs to be updated to V2
3 participants