-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update examples to V2 #289
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add instructions for configuring environment variables * Include helper for generating sender/receiver pairs
* Abstract away the reading and validation of basic configuration information from environment variables into a utility function * Include receiver mnemonic when generating sender and receiver accounts * Update note field example to use receiver mnemonic instead of receiver address
* Improve comments in transaction group example and note field example
* Move console formatting codes from sender receiver generation example to example utils * Add trace to error when bad arguments inputted to the `waitForConfirmation` function
* Fix webapp account address input length issue * Fix script path in webapp * Upgrade web app to use Algodv2 client
jasonpaulos
suggested changes
Mar 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a much-needed improvement! I've left a few small comments, but besides those everything looks good.
* Use Uint8Array for metadata instead of string * Include decimals parameter * Rename misspelled transaction parameters
…ion transaction examples
jasonpaulos
approved these changes
Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issues with the existing web app and adds a standard set of example scripts to the
examples
directory.Fixes #254.