Fix React multisig error #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
mergeMultisigTransactionsfunction currently does not work when used in a React app because it callsBuffer.comparewith Uint8Array arguments. The latest version of thebufferpackage supports this, but unfortunately react-scripts v4.0.1 uses an older version of webpack to build apps, which overrides thebufferpackage with an older version that does not support comparing Uint8Arrays.This PR converts the Uint8Array arguments to Buffers before calling
Buffer.compareto fix this issue.When react-scripts updates to webpack v5 (tracked by this issue), it should stop overriding the
buffermodule and this change can be reverted.Fixes #252.