Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MakeFoo family of functions get alternate FromObject method of calling #246

Merged
merged 3 commits into from
Nov 20, 2020
Merged

MakeFoo family of functions get alternate FromObject method of calling #246

merged 3 commits into from
Nov 20, 2020

Conversation

EvanJRichard
Copy link
Contributor

@EvanJRichard EvanJRichard commented Nov 19, 2020 •
edited
Loading

Closes #159

@EvanJRichard
Copy link
Contributor Author

@jasonpaulos do you know anything about this error? https://travis-ci.com/github/algorand/js-algorand-sdk/jobs/443837553

@jasonpaulos
Copy link
Contributor

Yes, that's because a new chrome version came out that broke compatibility. I have a fix for this in #247.

@EvanJRichard EvanJRichard marked this pull request as ready for review November 19, 2020 20:34
@EvanJRichard
Copy link
Contributor Author

@jasonpaulos 🤔 the build is still failing, maybe I need to refresh something somewhere

@jasonpaulos
Copy link
Contributor

@EvanJRichard if you rebase off develop, it should be fixed.

@EvanJRichard EvanJRichard changed the title DRAFT: MakeFoo family of functions get alternate FromObject method of calling MakeFoo family of functions get alternate FromObject method of calling Nov 19, 2020
@EvanJRichard
Copy link
Contributor Author

@jasonpaulos nice, I thought restarting the build would be enough alone. thanks!

jasonpaulos
jasonpaulos approved these changes Nov 20, 2020
View reviewed changes
Copy link
Contributor

@jasonpaulos jasonpaulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for taking the time to write out all those args

@EvanJRichard EvanJRichard merged commit 5d4dd31 into develop Nov 20, 2020
@EvanJRichard EvanJRichard deleted the evan/support_obj_args branch November 20, 2020 15:51
@jasonpaulos jasonpaulos mentioned this pull request Nov 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonpaulos jasonpaulos jasonpaulos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Discussion/Enhancement: Allow object arguments as inputs to asset functions
2 participants
@EvanJRichard @jasonpaulos