Fix: Ensure requests for asset/application id 0 check for the correct result #1622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xer queries for assets, apps, and transactions. Meant to resolve issue 1087, where requesting the 0 indexed asset/application resulted in a search query returning an incorrect creatable.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1622 +/- ##
==========================================
+ Coverage 68.69% 68.71% +0.02%
==========================================
Files 38 38
Lines 7529 7528 -1
==========================================
+ Hits 5172 5173 +1
+ Misses 1926 1924 -2
Partials 431 431 ☔ View full report in Codecov by Sentry. |
algorandskiy
approved these changes
Aug 9, 2024
jasonpaulos
approved these changes
Aug 9, 2024
jasonpaulos
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Make assetId and applicationId arguments pointers across several indexer queries for assets, apps, and transactions. Meant to resolve #1087, where requesting the 0 indexed asset/application resulted in a search query returning an incorrect creatable.
Test Plan
Existing tests are updated and passed. Manually tested the problematic queries.