Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accountdb: add migration 8 for resetting accounthashes on betanet #4822

Merged

Conversation

cce
Copy link
Contributor

@cce cce commented Nov 21, 2022

Summary

Following on #4804 and #4812, this migration rebuilds the accounthashes table for betanet nodes.

Test Plan

Existing tests should pass, manual tests can confirm table is rebuilt.

@cce cce force-pushed the reset-betanet-accounthashes-migration branch from 9d3afc8 to 15663b0 Compare November 21, 2022 16:24
ledger/trackerdb.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 21, 2022

Codecov Report

Merging #4822 (b3073dd) into master (d80de1a) will decrease coverage by 0.02%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##           master    #4822      +/-   ##
==========================================
- Coverage   54.67%   54.65%   -0.03%     
==========================================
  Files         417      417              
  Lines       53734    53749      +15     
==========================================
- Hits        29381    29377       -4     
- Misses      21920    21939      +19     
  Partials     2433     2433              
Impacted Files Coverage Δ
ledger/accountdb.go 72.35% <ø> (ø)
ledger/catchupaccessor.go 63.60% <0.00%> (-0.24%) ⬇️
ledger/trackerdb.go 46.64% <46.15%> (-0.03%) ⬇️
ledger/roundlru.go 90.56% <0.00%> (-5.67%) ⬇️
ledger/tracker.go 74.89% <0.00%> (-2.98%) ⬇️
catchup/peerSelector.go 98.95% <0.00%> (-1.05%) ⬇️
catchup/service.go 68.22% <0.00%> (-0.74%) ⬇️
network/wsPeer.go 71.36% <0.00%> (-0.72%) ⬇️
ledger/acctupdates.go 69.51% <0.00%> (-0.37%) ⬇️
network/wsNetwork.go 67.17% <0.00%> (+0.17%) ⬆️
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@onetechnical onetechnical merged commit b66a955 into algorand:master Nov 21, 2022
@onetechnical
Copy link
Contributor

Chris manually tested this on his database, so merging after a review.

@cce cce deleted the reset-betanet-accounthashes-migration branch November 22, 2022 17:19
algolucky pushed a commit to algolucky/go-algorand that referenced this pull request Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants