-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Fix GHA failure notification trigger condition #4810
CI: Fix GHA failure notification trigger condition #4810
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4810 +/- ##
==========================================
- Coverage 54.67% 54.66% -0.01%
==========================================
Files 414 414
Lines 53550 53550
==========================================
- Hits 29279 29275 -4
- Misses 21843 21847 +4
Partials 2428 2428
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@michaeldiamant can we clarify here are we trying to have notifications for
I think with this PR we are switching from 1 to 2. Please correct me if i misunderstand the description. |
Seems like this is intentional. so LGTM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this change is correct to change from base_ref
to ref_name
.
It might be a separate discussion on whether we only want to notify on failures for these particular branches.
Amends the trigger condition for Github Action (GHA) failure notification so that it only reaches out when the branch being built matches
master
or a release branch.From the docs in https://docs.github.com/en/actions/learn-github-actions/contexts:
Details:
ref_name
.