Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Add test defending against regression in testnet genesis generation #4741

Merged
merged 2 commits into from
Nov 3, 2022

Conversation

michaeldiamant
Copy link
Contributor

Attempts to address the following question from #4643 (review):

Can we somehow check if this generates the genesis for testnet as well?

Adds a test confirming gen/testnet.json matches installer/genesis/testnet/genesis.json excluding blotted out fields.

@michaeldiamant michaeldiamant changed the title Add test defending against testnet genesis generation Tests: Add test defending against testnet genesis generation Nov 3, 2022
@michaeldiamant michaeldiamant marked this pull request as ready for review November 3, 2022 02:07
@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Merging #4741 (c22866f) into master (fa77937) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4741      +/-   ##
==========================================
- Coverage   54.62%   54.55%   -0.07%     
==========================================
  Files         414      414              
  Lines       53514    53514              
==========================================
- Hits        29231    29197      -34     
- Misses      21860    21887      +27     
- Partials     2423     2430       +7     
Impacted Files Coverage Δ
ledger/roundlru.go 90.56% <0.00%> (-5.67%) ⬇️
ledger/blockqueue.go 85.63% <0.00%> (-2.88%) ⬇️
crypto/merkletrie/trie.go 66.42% <0.00%> (-2.19%) ⬇️
agreement/cryptoVerifier.go 67.60% <0.00%> (-2.12%) ⬇️
agreement/proposalManager.go 96.07% <0.00%> (-1.97%) ⬇️
network/wsPeer.go 66.50% <0.00%> (-1.95%) ⬇️
crypto/merkletrie/node.go 91.62% <0.00%> (-1.87%) ⬇️
network/wsNetwork.go 65.34% <0.00%> (-0.37%) ⬇️
ledger/acctupdates.go 69.05% <0.00%> (-0.25%) ⬇️
catchup/service.go 68.88% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@algorandskiy algorandskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Michael for the auto test. I honestly thought about one time manual test as a safety measure for that particular PR.

gen/generate_test.go Show resolved Hide resolved
gen/testnet.json Outdated Show resolved Hide resolved
@michaeldiamant michaeldiamant changed the title Tests: Add test defending against testnet genesis generation Tests: Add test defending against regression in testnet genesis generation Nov 3, 2022
@algorandskiy algorandskiy merged commit 7fcfe26 into algorand:master Nov 3, 2022
@michaeldiamant michaeldiamant deleted the testnet_gen_test branch November 4, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants