Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assert that Atomic Transaction Composer's method adder checks for arg-length consistency #189

Merged
merged 9 commits into from
Jun 17, 2022
Merged

Assert that Atomic Transaction Composer's method adder checks for arg-length consistency #189

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a9c185f
Test that asserts Atomic Transaction Composer enforces the same lengt…
Jun 14, 2022
fbbc3c4
more simple cases
Jun 14, 2022
6e18fdd
colon
Jun 14, 2022
1fba951
Then instead of And
Jun 14, 2022
88e961f
break the tuple jamming arglen bound
Jun 14, 2022
aeeb0e8
Update features/integration/abi.feature
tzaffi Jun 14, 2022
414ede1
recast the argument count check scenario outline as a unit test
Jun 16, 2022
95f2752
per CR suggestion: follow a more flexible approach in asserting the a…
Jun 16, 2022
e84d1bb
tag the "Method call argument count validation" scenarios with @unit…
Jun 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions features/unit/atomic_transaction_composer.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,3 +170,33 @@ Feature: Atomic Transaction Composer
Given a new AtomicTransactionComposer
When I build the transaction group with the composer. If there is an error it is "zero group size error".
Then The composer should have a status of "BUILDING".

@unit.atc_method_args
Scenario Outline: Method call argument count validation
Given a new AtomicTransactionComposer
And suggested transaction parameters fee 1234, flat-fee "true", first-valid 9000, last-valid 9010, genesis-hash "Mf0h6zjkEIEZPtNM3zsrg+iHQFS0fZxhgr7w35I464M=", genesis-id "cucumbernet"
And I make a transaction signer for the signing account.
And an application id 42
When I create the Method object from method signature "<method-signature>"
And I create a new method arguments array.
And I append the encoded arguments "<app-args>" to the method arguments array.
# When "none" is provided for <none-or-exception-pattern> there should be no exception, otherwise, the error's message should satisfy the regex:
Then I add a method call with the signing account, the current application, suggested params, on complete "noop", current transaction signer, current method arguments; any resulting exception has key "<none-or-exception-key>".

Examples:
| method-signature | app-args | none-or-exception-key |
| add(uint64,uint64)uint64 | AAAAAAAAAAE=,AAAAAAAAAAI= | none |
| empty()void | | none |
| f15(string,string,string,string,string,string,string,string,string,string,string,string,string,string,string)void | AAFh,AAFi,AAFj,AAFk,AAFl,AAFm,AAFn,AAFo,AAFp,AAFq,AAFr,AAFs,AAFt,AAFu,AAFv | none |
| f16(uint8,uint8,uint8,uint8,uint8,uint8,uint8,uint8,uint8,uint8,uint8,uint8,uint8,uint8,uint8,uint8)void | AA==,AQ==,Ag==,Aw==,BA==,BQ==,Bg==,Bw==,CA==,CQ==,Cg==,Cw==,DA==,DQ==,Dg==,Dw== | none |
| f17(uint8,uint8,uint8,uint8,uint8,uint8,uint8,uint8,uint8,uint8,uint8,uint8,uint8,uint8,uint8,uint8,uint8)void | AA==,AQ==,Ag==,Aw==,BA==,BQ==,Bg==,Bw==,CA==,CQ==,Cg==,Cw==,DA==,DQ==,Dg==,Dw==,Dw== | none |
| add(uint64,uint64)uint64 | AAAAAAAAAAE=,AAAAAAAAAAI=,AAAAAAAAAAI= | argument_count_mismatch |
| add(uint64,uint64)uint64 | AAAAAAAAAAE= | argument_count_mismatch |
| empty()void | AAAAAAAAAAE= | argument_count_mismatch |
| f15(string,string,string,string,string,string,string,string,string,string,string,string,string,string,string)void | AAFh,AAFi,AAFj,AAFk,AAFl,AAFm,AAFn,AAFo,AAFp,AAFq,AAFr,AAFs,AAFt,AAFu | argument_count_mismatch |
| f15(string,string,string,string,string,string,string,string,string,string,string,string,string,string,string)void | AAFh,AAFi,AAFj,AAFk,AAFl,AAFm,AAFn,AAFo,AAFp,AAFq,AAFr,AAFs,AAFt,AAFu,AAFu,AAFu | argument_count_mismatch |
| f16(uint8,uint8,uint8,uint8,uint8,uint8,uint8,uint8,uint8,uint8,uint8,uint8,uint8,uint8,uint8,uint8)void | AA==,AQ==,Ag==,Aw==,BA==,BQ==,Bg==,Bw==,CA==,CQ==,Cg==,Cw==,DA==,DQ==,Dg== | argument_count_mismatch |
| f16(uint8,uint8,uint8,uint8,uint8,uint8,uint8,uint8,uint8,uint8,uint8,uint8,uint8,uint8,uint8,uint8)void | AA==,AQ==,Ag==,Aw==,BA==,BQ==,Bg==,Bw==,CA==,CQ==,Cg==,Cw==,DA==,DQ==,Dg==,Dw==,Dw== | argument_count_mismatch |
| f17(uint8,uint8,uint8,uint8,uint8,uint8,uint8,uint8,uint8,uint8,uint8,uint8,uint8,uint8,uint8,uint8,uint8)void | AA==,AQ==,Ag==,Aw==,BA==,BQ==,Bg==,Bw==,CA==,CQ==,Cg==,Cw==,DA==,DQ==,Dg== | argument_count_mismatch |
| f17(uint8,uint8,uint8,uint8,uint8,uint8,uint8,uint8,uint8,uint8,uint8,uint8,uint8,uint8,uint8,uint8,uint8)void | AA==,AQ==,Ag==,Aw==,BA==,BQ==,Bg==,Bw==,CA==,CQ==,Cg==,Cw==,DA==,DQ==,Dg==,Dw== | argument_count_mismatch |
| f17(uint8,uint8,uint8,uint8,uint8,uint8,uint8,uint8,uint8,uint8,uint8,uint8,uint8,uint8,uint8,uint8,uint8)void | AA==,AQ==,Ag==,Aw==,BA==,BQ==,Bg==,Bw==,CA==,CQ==,Cg==,Cw==,DA==,DQ==,Dg==,Dw==,Dw==,Dw== | argument_count_mismatch |