fix(shipjs-lib): exclude dependencies from final bundle (#651)

* add all dependencies to rollup externals * use imports Co-authored-by: Eunjae Lee <[email protected]>
algolia · Mar 6, 2020 · f6ec4cf · f6ec4cf
1 parent cd43798
commit f6ec4cf
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 16 deletions.
diff --git a/packages/shipjs-lib/rollup.config.js b/packages/shipjs-lib/rollup.config.js
@@ -6,7 +6,7 @@ export default [
   {
     input: 'src/index.js',
     output: [{ file: pkg.main, format: 'es' }],
-    external: ['fs', 'path', 'url'],
+    external: ['fs', 'path', 'url'].concat(Object.keys(pkg.dependencies)),
     plugins: [resolve({ preferBuiltins: true }), commonjs()],
   },
 ];
diff --git a/packages/shipjs-lib/src/lib/config/mergeConfig.js b/packages/shipjs-lib/src/lib/config/mergeConfig.js
@@ -1,4 +1,4 @@
-const merge = require('deepmerge');
+import merge from 'deepmerge';
 
 export default function mergeConfig(config1, config2) {
   const config = {

diff --git a/packages/shipjs-lib/src/lib/shell/exec.js b/packages/shipjs-lib/src/lib/shell/exec.js
@@ -1,17 +1,4 @@
-const shell = require('shelljs');
-/*
-  This used to be `import shell from 'shelljs'`.
-  For some reason I don't know, it broke the build.
-  
-  `var shellMethods = Object.create(shell);`
-  The line above is from the build output.
-  At the time it was executed, there was no `shell` defined yet.
-  So it threw the following:
-    TypeError: Object prototype may only be an Object or null: undefined
-
-  I tried many different things to fix this, but couldn't find a solution.
-  Using `require` instead of `import` is the only workaround at the moment.
-*/
+import shell from 'shelljs';
 
 export default function exec(
   command,