Skip to content

Commit

Permalink
feat(release): notify GitHub release url instead of CHANGELOG (#555)
Browse files Browse the repository at this point in the history
Notify GitHub release URL to Slack.
Fixes #506
  • Loading branch information
uetchy authored and Eunjae Lee committed Dec 24, 2019
1 parent 35b89c9 commit c017067
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 2 deletions.
5 changes: 3 additions & 2 deletions packages/shipjs-lib/src/lib/config/defaultConfig.js
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,7 @@ export default {
releaseSuccess: ({
appName,
version,
releaseTag,
latestCommitHash,
latestCommitUrl,
repoURL,
Expand All @@ -189,8 +190,8 @@ export default {
short: true,
},
{
title: 'CHANGELOG',
value: `${repoURL}/blob/master/CHANGELOG.md`,
title: 'Release',
value: `${repoURL}/releases/tag/${releaseTag}`,
},
],
}),
Expand Down
1 change: 1 addition & 0 deletions packages/shipjs/src/flow/release.js
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ async function release({ help = false, dir = '.', dryRun = false }) {
config,
appName,
version,
releaseTag,
latestCommitHash,
latestCommitUrl,
repoURL,
Expand Down
2 changes: 2 additions & 0 deletions packages/shipjs/src/step/release/notifyReleaseSuccess.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ export default async ({
config,
appName,
version,
releaseTag,
latestCommitHash,
latestCommitUrl,
repoURL,
Expand All @@ -22,6 +23,7 @@ export default async ({
config,
appName,
version,
releaseTag,
latestCommitHash,
latestCommitUrl,
repoURL,
Expand Down
2 changes: 2 additions & 0 deletions packages/shipjs/src/util/slack.js
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ export async function notifyReleaseSuccess({
config,
appName,
version,
releaseTag,
latestCommitHash,
latestCommitUrl,
repoURL,
Expand All @@ -80,6 +81,7 @@ export async function notifyReleaseSuccess({
? releaseSuccess({
appName,
version,
releaseTag,
latestCommitHash,
latestCommitUrl,
repoURL,
Expand Down

0 comments on commit c017067

Please sign in to comment.