This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
Migrate to React 16 everywhere #423
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just to test with CI
Remaining known issues:
recipes test passes but there seems to have a "timeout" issue that make the script failed. For instance, when removing the content of the autocomplete tests,
npm run test:recipespass.storybook is failing like crazy. See: Error when clicking on the menu item on React 16 storybookjs/storybook#1965
warning in test about Error Boundaries. See: Allow suppressing error boundary logs from intentionally thrown/caught errors facebook/react#11098 (not mandatory)