refactoring: remove obsolete polyfills #6417
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haroenv
reviewed
Oct 29, 2024
| @@ -16,7 +16,6 @@ | |||
| <script> | |||
| import { createSuitMixin } from '../mixins/suit'; | |||
| import { createWidgetMixin } from '../mixins/widget'; | |||
| import { _objectSpread } from '../util/polyfills'; | |||
There was a problem hiding this comment.
this is for babel in Vue InstantSearch, not for ie11
There was a problem hiding this comment.
I don't remember well why we resort to this, does the build fail if we use native object spreading in the codebase for Vue?
There was a problem hiding this comment.
yes, it was something along those lines, but if it works feel free to change
There was a problem hiding this comment.
Alright! I'll check this once I've merged FX-3053 into this branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes a number of polyfills we had in the library that are no longer necessary following the end of IE11 support.