Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(examples): set explicit typescript dev dependency for rish examples #5635

Merged
merged 1 commit into from
May 22, 2023

Conversation

dhayab
Copy link
Member

@dhayab dhayab commented May 19, 2023

Summary

This is a quick QOL change that prevents issues on CodeSandbox that could be related to an unsupported TypeScript version.

Result

Now users can copy/paste code from our doc to some of our sandboxes without having issues that could be related to the default TypeScript version available in CodeSandbox.

@dhayab dhayab requested review from a team, Haroenv and aymeric-giraudet and removed request for a team May 19, 2023 14:10
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4b760ec:

Sandbox Source
InstantSearch.js Configuration
react-instantsearch-app Configuration
algolia/instantsearch Configuration
algolia/instantsearch Configuration

@dhayab dhayab merged commit 162341a into master May 22, 2023
@dhayab dhayab deleted the chore/examples-explicit-typescript branch May 22, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants