Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade algoliasearch to v5 #2326

Merged
merged 14 commits into from
Oct 30, 2024
Merged

fix: upgrade algoliasearch to v5 #2326

merged 14 commits into from
Oct 30, 2024

Conversation

millotp
Copy link
Contributor

@millotp millotp commented Oct 29, 2024

We can use the new generated client to stay up to date and upgrade packages that depends on docsearch.

Copy link

netlify bot commented Oct 29, 2024

Deploy Preview for docsearch canceled.

Name Link
🔨 Latest commit 7e0dceb
🔍 Latest deploy log https://app.netlify.com/sites/docsearch/deploys/6722350300161f0008ccc764

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!! gg on your first commit :D

cc @francoischalifour in case you want to double check

@@ -6,11 +6,11 @@
},
{
"path": "packages/docsearch-react/dist/umd/index.js",
"maxSize": "23 kB"
"maxSize": "27 kB"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

too bad the bundler doesn't resolve to the minified version :(

@millotp millotp merged commit 93578a4 into main Oct 30, 2024
10 checks passed
@millotp millotp deleted the fix/upgrade-v5 branch October 30, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants