Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hits): default to hierarchy lvl0 if highlights present #2309

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

shortcuts
Copy link
Member

https://algolia.atlassian.net/browse/DI-2986

There seems to be a bug on the indexing side which impacts some DocSearch users. This bug has been reported to me by @rickhanlonii and fixed in reactjs/react.dev#7183 temporarily, but we can globally mitigate this issue which also impacts other DocSearch users such as https://vuejs.org/, https://tailwindcss.com/

We now default to the non highlighted lvl0 in case the highlightResult value is not present

You can try this fix by running yarn playground:start on main and this branch:

  • On main (or just https://vuejs.org/), no section appears (cf screenshot 1
  • On this branch (cf screenshot 2)

Screenshot 2024-09-27 at 10 31 16

Screenshot 2024-09-27 at 10 31 53

@shortcuts shortcuts self-assigned this Sep 27, 2024
Copy link

netlify bot commented Sep 27, 2024

Deploy Preview for docsearch canceled.

Name Link
🔨 Latest commit 43edc1e
🔍 Latest deploy log https://app.netlify.com/sites/docsearch/deploys/66f66d9e169a9e00085196e3

Copy link

@morganleroi morganleroi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go !

@shortcuts shortcuts merged commit 5260d1e into main Sep 27, 2024
10 checks passed
@shortcuts shortcuts deleted the fix/lvl0-not-highlighted branch September 27, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants