Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

External links (github, algolia) break when opened from Sandbox #147

Open
pmoskovi opened this issue Sep 30, 2021 · 0 comments
Open

External links (github, algolia) break when opened from Sandbox #147

pmoskovi opened this issue Sep 30, 2021 · 0 comments

Comments

@pmoskovi
Copy link

The footer of the sandbox renders links to GitHub and Algolia.
image

These links cannot be opened in the same frame:
image

Error message in browser console:
Refused to frame 'https://github.com/' because an ancestor violates the following Content Security Policy directive: "frame-ancestors 'none'".

Suggested fix: add target=_blank to external links to force link opening in new tab.
pmoskovi pushed a commit to pmoskovi/doc-onboarding that referenced this issue Sep 30, 2021
External links (github, algolia) break when opened from Sandbox algol…
6c2e20e 
…ia#147
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pmoskovi