Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

refactor(index): rewrite answer parsing #541

Merged
merged 20 commits into from
Dec 2, 2021
Merged

refactor(index): rewrite answer parsing #541

merged 20 commits into from
Dec 2, 2021

Commits on Nov 25, 2021

  1. refactor(index): rewrite answer parsing 

    There were a couple things that didn't work as expected

- isQuestionAsked actually implemented shouldQuestionBeAsked (opposite to the name)
- getOptionsFromArguments isn't needed, Commander already exposes arguments
- splitting array manually can be done in Commander
- confusing "when" conditional for array values
- validation of appName can be done inline so it doesn't error
    @Haroenv
    Haroenv committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    826c27e View commit details
    Browse the repository at this point in the history

  2. postprocess answers

    @Haroenv
    Haroenv committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    c745986 View commit details
    Browse the repository at this point in the history

  3. e2e installs should not have any asked questions

    @Haroenv
    Haroenv committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    5509036 View commit details
    Browse the repository at this point in the history

  4. make e2e build test pass

    @Haroenv
    Haroenv committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    b16efc6 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2021

  1. more info

    @Haroenv
    Haroenv committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    06596eb View commit details
    Browse the repository at this point in the history

  2. update to newer commander to fix the "name" issue

    @Haroenv
    Haroenv committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    0b21168 View commit details
    Browse the repository at this point in the history

  3. refactor: validate appPath like appName

    @Haroenv
    Haroenv committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    11aee59 View commit details
    Browse the repository at this point in the history

  4. error for empty string path

    @Haroenv
    Haroenv committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    80eabed View commit details
    Browse the repository at this point in the history

  5. clean lockfile

    @Haroenv
    Haroenv committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    2b62f23 View commit details
    Browse the repository at this point in the history

  6. refactor initial questions

    @Haroenv
    Haroenv committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    df117dc View commit details
    Browse the repository at this point in the history

  7. silently check for existing answers on appName

    @Haroenv
    Haroenv committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    051c9a0 View commit details
    Browse the repository at this point in the history

  8. don't ask initial questions if config is set

    @Haroenv
    Haroenv committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    71c745e View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2021

  1. introduce --no-interactive, mostly for test

    @Haroenv
    Haroenv committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    ecdbbc7 View commit details
    Browse the repository at this point in the history

  2. write tests

    @Haroenv
    Haroenv committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    371419e View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2021

  1. fix argument

    @Haroenv
    Haroenv committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    6fd91aa View commit details
    Browse the repository at this point in the history

  2. undo change

    @Haroenv
    Haroenv committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    3e425b3 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2021

  1. make .default apply always

    @Haroenv
    Haroenv committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    fe8bcf2 View commit details
    Browse the repository at this point in the history

  2. refactor templates to be part of initialQuestions

    @Haroenv
    Haroenv committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    c3032d3 View commit details
    Browse the repository at this point in the history

  3. cover initialQuestions in tests

    @Haroenv
    Haroenv committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    be4b49d View commit details
    Browse the repository at this point in the history

  4. fix error

    @Haroenv
    Haroenv committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    e067902 View commit details
    Browse the repository at this point in the history