Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

feat(templates): add React Native templates #53

Merged
merged 1 commit into from
Jun 14, 2018

Conversation

samouss
Copy link
Contributor

@samouss samouss commented Jun 13, 2018

The PR adds a "React InstantSearch Native" template that use react-instantsearch-native.

  • The template don't handle attributesForFacetting it's a bit hard to implement because there is a lots of condition. The code is a bit more complicated than the web in order to have a RefinementList
  • In case we don't provide mainAttribute the Highlight file is generated but unused

simulator screen shot - iphone x - 2018-06-13 at 19 21 11

Copy link
Member

@francoischalifour francoischalifour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great, thank you for this!

@francoischalifour
Copy link
Member

One thing to note is that although this template will be released in the templates branch, it won't be available on CodeSandbox.

Could we offer a similar experience with React Native? With Expo?

@Haroenv
Copy link
Contributor

Haroenv commented Jun 14, 2018

seems like it's possible: https://forums.expo.io/t/modules-available-in-snack/1651/16

@francoischalifour
Copy link
Member

Can it be loaded from a GitHub URL?

@Haroenv
Copy link
Contributor

Haroenv commented Jun 14, 2018

looking for that option now (asked on twitter)

edit: quickly made sure it worked in snack: https://snack.expo.io/B1RIWR1ZQ, not sure yet how to load from url

@samouss
Copy link
Contributor Author

samouss commented Jun 14, 2018

Yes it would be nice but at least the template is available from the CLI.

@francoischalifour francoischalifour merged commit 8b14d31 into master Jun 14, 2018
@francoischalifour francoischalifour deleted the feat/react-native branch June 14, 2018 13:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants