This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
refactor(index): rewrite answer parsing #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were a couple things that didn't work as expected - isQuestionAsked actually implemented shouldQuestionBeAsked (opposite to the name) - getOptionsFromArguments isn't needed, Commander already exposes arguments - splitting array manually can be done in Commander - confusing "when" conditional for array values - validation of appName can be done inline so it doesn't error
Haroenv
requested review from
a team,
dhayab and
tkrugg
and removed request for
a team
francoischalifour
approved these changes
Dec 2, 2021
| message: 'Project directory', | ||
| const isValid = Boolean(input); | ||
| if (!isValid) { | ||
| console.log('template is required'); |
There was a problem hiding this comment.
This console.log shouldn't be required, our script errors by itself like with other options, right?
There was a problem hiding this comment.
it would error in
, but increate-instantsearch-app/src/cli/index.js
Line 339 in e067902
aymeric-giraudet
pushed a commit
to algolia/instantsearch
that referenced
this pull request
Dec 14, 2022
…-app#541) * refactor(index): rewrite answer parsing There were a couple things that didn't work as expected - isQuestionAsked actually implemented shouldQuestionBeAsked (opposite to the name) - getOptionsFromArguments isn't needed, Commander already exposes arguments - splitting array manually can be done in Commander - confusing "when" conditional for array values - validation of appName can be done inline so it doesn't error BREAKING CHANGE: the program now asks questions if some of the parameters are sent via arguments. Before this, giving an argument would cause it not to ask any questions anymore, even if they still would be useful. You can avoid this behaviour by passing --config or --no-interactive * postprocess answers * e2e installs should not have any asked questions * make e2e build test pass * more info * update to newer commander to fix the "name" issue * refactor: validate appPath like appName * error for empty string path * clean lockfile * refactor initial questions * silently check for existing answers on appName * don't ask initial questions if config is set * introduce --no-interactive, mostly for test * write tests * fix argument * undo change * make .default apply always * refactor templates to be part of initialQuestions * cover initialQuestions in tests * fix error
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a couple things that didn't work as expected
BREAKING CHANGE: it now asks questions if some of the parameters are sent via arguments. Before this, giving an argument would cause it not to ask any questions anymore, even if they still would be useful. You can avoid this behaviour by passing --config or --no-interactive