This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
fix(React InstantSearch): placeholder template #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cc @biletron @francoischalifour, do you think the double brace could confuse handlebars?
|
You have to update the E2E snapshots. |
|
Thanks for fixing this! You'll need to escape the curly brackets: Also, don't forget to update the snapshots. |
francoischalifour
approved these changes
Feb 12, 2019
aymeric-giraudet
pushed a commit
to algolia/instantsearch
that referenced
this pull request
Dec 14, 2022
…tsearch-app#361) * fix(React InstantSearch): placeholder template cc @biletron @francoischalifour, do you think the double brace could confuse handlebars? * Update App.js.hbs * fix: escape the handlebars-like format
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @biletron
@francoischalifour, do you think the double brace could confuse handlebars?