Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Commit

Permalink
fix(React InstantSearch): placeholder template (#361)
Browse files Browse the repository at this point in the history
* fix(React InstantSearch): placeholder template

cc @biletron

@francoischalifour, do you think the double brace could confuse handlebars?

* Update App.js.hbs

* fix: escape the handlebars-like format
  • Loading branch information
Haroenv authored Feb 12, 2019
1 parent ac173dd commit caf15a0
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 2 deletions.
7 changes: 6 additions & 1 deletion scripts/__snapshots__/e2e-templates.test.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -4179,7 +4179,12 @@ class App extends Component {
</div>
<div className=\\"search-panel__results\\">
<SearchBox className=\\"searchbox\\" placeholder=\\"Search placeholder\\" />
<SearchBox
className=\\"searchbox\\"
translations={{
placeholder: 'Search placeholder',
}}
/>
<Hits hitComponent={Hit} />
<div className=\\"pagination\\">
Expand Down
7 changes: 6 additions & 1 deletion src/templates/React InstantSearch/src/App.js.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,12 @@ class App extends Component {

{{/if}}
<div className="search-panel__results">
<SearchBox className="searchbox" placeholder="{{searchPlaceholder}}" />
<SearchBox
className="searchbox"
translations=\{{
placeholder: '{{searchPlaceholder}}',
}}
/>
<Hits hitComponent={Hit} />

<div className="pagination">
Expand Down

0 comments on commit caf15a0

Please sign in to comment.