fix(angular): do not launch the directive if autocomplete has a value #138
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #136
Summary
As described in #136 , we're bugging out the behavior of the HTML
autocomplete
attribute.You can't use
autocomplete="off"
in the current setup, this PR fixes it.Result
Checked in
test/playground_angular.html
.Attribute mode:
autocomplete
=> our autocomplete triggersautocomplete=""
=> our autocomplete triggersautocomplete="off"
=> our autocomplete doesn't trigger and it correctly prevents the browser from autocompletingdata-autocomplete
=> our autocomplete triggersI've also checked that the class mode of the directive still works.