Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(specs): update estimate response type [skip-bc] #4101

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

cdhawke
Copy link
Contributor

@cdhawke cdhawke commented Nov 13, 2024

🧭 What and Why

OPTIM-1329

Dependent on merge and deploy of https://github.com/algolia/go/pull/16975

Changes included:

Changed the response type to an array of integers, rather than static numbers to account for multiple variants in estimation

🧪 Test

  • All tests should pass

@cdhawke cdhawke self-assigned this Nov 13, 2024
@cdhawke cdhawke requested a review from a team as a code owner November 13, 2024 19:13
@algolia-bot
Copy link
Collaborator

algolia-bot commented Nov 13, 2024

✔️ Code generated!

Name Link
🪓 Triggered by 592af9b94ace708ea02c171849da47bc3f693ef3
🍃 Generated commit 464deafd43f7d7470cabbe0125778fe3d7f5d03c
🌲 Generated branch generated/feat/abtests/estimate-response
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
swift 754

@millotp millotp changed the title feat(abtests): update estimate response type [skip-bc] feat(specs): update estimate response type [skip-bc] Nov 13, 2024
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good !

@millotp millotp merged commit 39ad054 into main Nov 14, 2024
27 of 34 checks passed
@millotp millotp deleted the feat/abtests/estimate-response branch November 14, 2024 08:58
algolia-bot added a commit that referenced this pull request Nov 14, 2024
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Nov 14, 2024
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Nov 14, 2024
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Nov 14, 2024
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Nov 14, 2024
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Nov 14, 2024
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Nov 14, 2024
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Nov 14, 2024
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Nov 14, 2024
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Nov 14, 2024
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Nov 14, 2024
millotp pushed a commit that referenced this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants