Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(analytics): constrain pagination only to limit query parameter #4012

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

febeck
Copy link
Contributor

@febeck febeck commented Oct 21, 2024

🧭 What and Why

🎟 JIRA Ticket: OPTIM-1314

Changes included:

Update documents to reflect changes in the API brought by https://github.com/algolia/go/pull/16694

  • Remove limitation on offset + limit combined limit and update documentation to reflect the changes

🧪 Test

@febeck febeck requested a review from a team as a code owner October 21, 2024 12:35
@algolia-bot
Copy link
Collaborator

algolia-bot commented Oct 21, 2024

✔️ Code generated!

Name Link
🪓 Triggered by 981103828def2ee9377343cfbbb2fab0eab4e272
🍃 Generated commit c73e66881afe483d79b3a9739d604a796dc05075
🌲 Generated branch generated/feat/analytics/remove_analytics_pagination_constraint
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 1689
go 1635
php 1457
csharp 1372
java 1131
python 1019
ruby 902
swift 756

@febeck febeck changed the title refactor(analytics): constrain pagination only to limit query parameter docs(analytics): constrain pagination only to limit query parameter Oct 21, 2024
@febeck febeck force-pushed the feat/analytics/remove_analytics_pagination_constraint branch from c6ccb3d to d11c082 Compare October 21, 2024 12:44
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good!

can I go ahead and merge?

@febeck
Copy link
Contributor Author

febeck commented Oct 21, 2024

can I go ahead and merge?

Thanks @shortcuts, yes you can

@shortcuts shortcuts merged commit fe2c844 into main Oct 21, 2024
28 checks passed
@shortcuts shortcuts deleted the feat/analytics/remove_analytics_pagination_constraint branch October 21, 2024 14:05
algolia-bot added a commit that referenced this pull request Oct 21, 2024
…4012) (generated) [skip ci]

Co-authored-by: Fernando Beck <[email protected]>
Co-authored-by: shortcuts <[email protected]>
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Oct 21, 2024
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Oct 21, 2024
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Oct 21, 2024
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Oct 21, 2024
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Oct 21, 2024
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Oct 21, 2024
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Oct 21, 2024
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Oct 21, 2024
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Oct 21, 2024
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants