fix(javascript): dependency imports and low-level init #3596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
shortcuts
commented
Aug 25, 2024
| @@ -276,6 +276,7 @@ export function buildConfigs(pkg) { | |||
| }), | |||
| nodeResolve({ | |||
| preferBuiltins: true, | |||
| browser: isUmdBuild || isEsmBrowserBuild, | |||
There was a problem hiding this comment.
see https://www.npmjs.com/package/@rollup/plugin-node-resolve#browser, I should've set that way before D:
There was a problem hiding this comment.
ok it's not fully working
shortcuts
commented
Aug 25, 2024
| ...initOptions.options, | ||
| ...initOptions, | ||
| }); | ||
| return recommendClient(initOptions.appId || appId, initOptions.apiKey ||apiKey, initOptions.options); |
There was a problem hiding this comment.
this is redundant and I think was legacy, now that standalone clients checks it, we don't need it here
shortcuts
force-pushed
the
fix/javascript-algoliasearch-build
branch
from
d953385 to
85dec20
Compare
shortcuts
force-pushed
the
fix/javascript-algoliasearch-build
branch
from
85dec20 to
5204d8d
Compare
shortcuts
force-pushed
the
fix/javascript-algoliasearch-build
branch
from
5204d8d to
16c752d
Compare
algolia-bot
added a commit
that referenced
this pull request
Aug 28, 2024
…ated) [skip ci] Co-authored-by: Clément Vannicatte <[email protected]>
algolia-bot
added a commit
to algolia/algoliasearch-client-javascript
that referenced
this pull request
Aug 28, 2024
algolia/api-clients-automation#3596 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Clément Vannicatte <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-2828
Changes included:
closes algolia/algoliasearch-client-javascript#1538
we import from the src of the dependency which is fine in the monorepo context, but the path isn't correct when importing from the built package
we actually don't need the low level init method, we can just use the regular instance and spread it, it should behave the same