Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(specs): browse response required properties #3348

Merged
merged 7 commits into from
Jul 11, 2024
Merged

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Jul 10, 2024

🧭 What and Why

DI-2601

Noticed by @kai687, not all properties are required in the browse response compared to the search response.

@millotp millotp self-assigned this Jul 10, 2024
@millotp millotp requested a review from a team as a code owner July 10, 2024 13:27
@algolia-bot
Copy link
Collaborator

algolia-bot commented Jul 10, 2024

✔️ Code generated!

Name Link
🪓 Triggered by 80d5337db41a4b0a9b2f60ffd5bfd8408e175e59
🍃 Generated commit 1eeb72f04808953126b6f5b9c0c5d260ac269299
🌲 Generated branch generated/fix/browse-response

Copy link

github-actions bot commented Jul 10, 2024

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Magnificent

@millotp millotp merged commit a009967 into main Jul 11, 2024
21 checks passed
@millotp millotp deleted the fix/browse-response branch July 11, 2024 15:30
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Jul 11, 2024
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Jul 11, 2024
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Jul 11, 2024
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Jul 11, 2024
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Jul 11, 2024
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Jul 11, 2024
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Jul 11, 2024
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Jul 11, 2024
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Jul 11, 2024
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants