Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(clients): remove unused models from lite clients #3159

Merged
merged 2 commits into from
Jun 11, 2024
Merged

fix(clients): remove unused models from lite clients #3159

merged 2 commits into from
Jun 11, 2024

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Jun 11, 2024 •
edited
Loading

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-2440

Changes included:

js and dart ships unused models because the lite specs keep them

@shortcuts shortcuts self-assigned this Jun 11, 2024
@algolia-bot
Copy link
Collaborator

algolia-bot commented Jun 11, 2024 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 11, 2024 •
edited
Loading

🚀 Deployed on https://6668481ebef6d2090e6c643b--api-clients-automation.netlify.app

@github-actions github-actions bot temporarily deployed to pull request June 11, 2024 11:51 Inactive
@shortcuts shortcuts marked this pull request as ready for review June 11, 2024 11:54
@shortcuts shortcuts requested a review from a team as a code owner June 11, 2024 11:54
@shortcuts shortcuts requested review from damcou and Fluf22 June 11, 2024 11:54
@millotp
Copy link
Collaborator

millotp commented Jun 11, 2024

so nice ! too bad it doesn't impact the bundle size for js

Screenshot 2024-06-11 at 14 29 13

@shortcuts
Copy link
Member Author

so nice ! too bad it doesn't impact the bundle size for js

Screenshot 2024-06-11 at 14 29 13

yes the umd doesn't include the models it's pure js, it might impact the final esm bundle size though

millotp
millotp approved these changes Jun 11, 2024
View reviewed changes
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gg ! this could be used to find dead specs also, if we have any

@shortcuts shortcuts enabled auto-merge (squash) June 11, 2024 12:36
@shortcuts
Copy link
Member Author

gg ! this could be used to find dead specs also, if we have any

yup definitely!!

@github-actions github-actions bot temporarily deployed to pull request June 11, 2024 12:50 Inactive
@shortcuts shortcuts merged commit 072c38b into main Jun 11, 2024
25 checks passed
@shortcuts shortcuts deleted the fix/remove-unused-components-lite branch June 11, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millotp millotp millotp approved these changes

@damcou damcou Awaiting requested review from damcou damcou is a code owner automatically assigned from algolia/api-clients-automation

@Fluf22 Fluf22 Awaiting requested review from Fluf22 Fluf22 is a code owner automatically assigned from algolia/api-clients-automation

Assignees

@shortcuts shortcuts

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shortcuts @algolia-bot @millotp