-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(specs): recommend api #2958
Conversation
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
No idea why Dart fails, but Java, Kotlin, Scala fails because |
I guess so yes if it's expected to have this format, but it might be an issue with the CTS template |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe @raed667 @marialungu @francoischalifour can help for the review on this one
for the recommended for you, I know it's available in the JavaScript client https://github.com/search?q=repo%3Aalgolia%2Falgoliasearch-client-javascript%20recommended-for-you&type=code
Changed the integers in the test to a float to make the test pass, but the API also accepts integers... Python fails because of a test for generatedSecuredAPIkeys(), which is unrelated to this PR. And indeed, |
since it has been added by the recommend team on the javascript client we should keep it for now and let them remove it if necessary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
purrrrfect
🧭 What and Why
Update the spec for the Recommend API to make it suitable as API reference
Changes included:
x-algolia...
headers lowercase. HTTP headers are case-insensitive anyway. It just looks better IMO.Things that will still be wrong
Fixing this requires some remodeling in the "common" parameters/Search API response,
which might break things unrelated to Recommend.
queryParameters
for getting recommendations does not accepthitsPerPage
,page
,offset
,length
.🧪 Test
TODO: fix tests for the new responses.