Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ruby): exclude vendor from bundled gem #2512

Merged
merged 1 commit into from
Jan 9, 2024
Merged

fix(ruby): exclude vendor from bundled gem #2512

merged 1 commit into from
Jan 9, 2024

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Jan 9, 2024

🧭 What and Why

The published gem was 5.4MB instead of the expected 300KB, because I forgot to remove files excluded by git.

@millotp millotp self-assigned this Jan 9, 2024
@millotp millotp requested a review from a team as a code owner January 9, 2024 16:51
@millotp millotp requested review from damcou and Fluf22 January 9, 2024 16:51
Copy link

netlify bot commented Jan 9, 2024

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit c42aa8c
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/659d798537e39600078b20b0
😎 Deploy Preview https://deploy-preview-2512--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops great catch! it doesn't follow the gitignore?

@millotp
Copy link
Collaborator Author

millotp commented Jan 9, 2024

if I don't specify it it won't !

@algolia-bot
Copy link
Collaborator

algolia-bot commented Jan 9, 2024

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@millotp millotp merged commit 7085d09 into main Jan 9, 2024
16 checks passed
@millotp millotp deleted the fix/ruby-vendor branch January 9, 2024 17:12
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants