Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(scripts): replace config path #2510

Merged
merged 1 commit into from
Jan 9, 2024
Merged

chore(scripts): replace config path #2510

merged 1 commit into from
Jan 9, 2024

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Jan 9, 2024

🧭 What and Why

By default, we need to rebuild the scripts everytime we change the the config files, but this is less than ideal.
The only way I found to fix it was by using a library, tsc-alias, that will replace after the transpilation every reference to ../config with ../../../config to fetch the original file.
Using paths, or dynamic import didn't work

@millotp millotp self-assigned this Jan 9, 2024
@millotp millotp requested a review from a team as a code owner January 9, 2024 16:32
Copy link

netlify bot commented Jan 9, 2024

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 590747d
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/659d7535415c1300084ca6d1
😎 Deploy Preview https://deploy-preview-2510--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Jan 9, 2024

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with that! great job finding an alternative, such a huge case D:

@millotp millotp merged commit 35b1574 into main Jan 9, 2024
27 checks passed
@millotp millotp deleted the chore/original-json branch January 9, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants