Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(specs): port recommend changes #2476

Merged
merged 8 commits into from
Jan 4, 2024
Merged

fix(specs): port recommend changes #2476

merged 8 commits into from
Jan 4, 2024

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Jan 4, 2024

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-1741

closes #2336

Changes included:

  • fix trending facet hits
  • add recommended for you models
  • match naming with current client

@shortcuts shortcuts self-assigned this Jan 4, 2024
Copy link

netlify bot commented Jan 4, 2024

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 27ddb90
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/6596b49e4ebbc000073092c2
😎 Deploy Preview https://deploy-preview-2476--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Jan 4, 2024

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@shortcuts shortcuts marked this pull request as ready for review January 4, 2024 12:23
@shortcuts shortcuts requested a review from a team as a code owner January 4, 2024 12:23
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good ! but this is a breaking change for dart, is it okay ?

@shortcuts
Copy link
Member Author

looks good ! but this is a breaking change for dart, is it okay ?

I think so yes, IIRC it's mostly used in JS and pretty new so it's more of a fix actually

@shortcuts shortcuts merged commit ae6adfb into main Jan 4, 2024
27 checks passed
@shortcuts shortcuts deleted the fix/recommend-specs branch January 4, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(specs) port PR from JS repository
3 participants