Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

ci(circle): update node image #875

Merged
merged 3 commits into from
Oct 7, 2021
Merged

ci(circle): update node image #875

merged 3 commits into from
Oct 7, 2021

Conversation

Haroenv
Copy link
Contributor

@Haroenv Haroenv commented Oct 7, 2021

@Haroenv Haroenv requested review from a team, tkrugg and sarahdayan and removed request for a team October 7, 2021 12:29
@Haroenv Haroenv marked this pull request as draft October 7, 2021 12:49
@Haroenv Haroenv marked this pull request as ready for review October 7, 2021 13:36
@@ -101,5 +101,8 @@
},
"peerDependencies": {
"algoliasearch": ">= 3.1 < 5"
},
"resolutions": {
"node-sass": "4.14.1"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

older versions weren't precompiled for this node version, thus required python, which is no longer included in the docker container

@Haroenv Haroenv merged commit 3648463 into develop Oct 7, 2021
@Haroenv Haroenv deleted the fix/ci branch October 7, 2021 13:44
Haroenv added a commit that referenced this pull request Oct 8, 2021
 * ci(circle): update node image (#875) 3648463
 * feat(facets): when * is present, only send that parameter (#874) fc183ec
dhayab pushed a commit to algolia/instantsearch that referenced this pull request Jul 10, 2023
* ci(circle): update node image

same as algolia/instantsearch.jsalgolia/algoliasearch-helper-js#4918

* try 8.17

* try upgrading more
dhayab pushed a commit to algolia/instantsearch that referenced this pull request Jul 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants