fix: dom-exception on access to localStorage #999
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #997
The access to the localStorage was being performed on the constructor of the
localStorage
driver making thealgoliasearch
function throwing the following exception:This pull request delays the access to the localStorage to the async API provided by
get
,set
, andclear
, so the error can becatch
- making thefallbackable
driver proxy to the next driver in the chain.algoliasearch-client-javascript/packages/cache-common/src/createFallbackableCache.ts
Line 21 in d862a91