Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): Updating searchoptions with explain attribute #1415

Merged
merged 2 commits into from
Jul 18, 2022
Merged

fix(types): Updating searchoptions with explain attribute #1415

merged 2 commits into from
Jul 18, 2022

Conversation

cdhawke
Copy link
Contributor

@cdhawke cdhawke commented Jul 18, 2022

Motivation

  • Update the SearchOptions to include explain as a typed parameter for better use within the Algolia dashboard

How

  • Adds the explain attribute as a string[] to the V4 SearchOptions.

Testing

  • Test cases shouldn't change. The attribute is already included in a search test here

@cdhawke cdhawke added the TypeScript Problems related to TypeScript definitions label Jul 18, 2022
@cdhawke cdhawke requested a review from Haroenv July 18, 2022 13:47
@cdhawke cdhawke self-assigned this Jul 18, 2022
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 18, 2022 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c0a9119:

Sandbox Source
javascript-client-app Configuration

@cdhawke cdhawke requested a review from Haroenv July 18, 2022 14:08
@Haroenv Haroenv changed the title feat(client-search): Updating searchoptions with explain attribute fix(types): Updating searchoptions with explain attribute Jul 18, 2022
@Haroenv Haroenv enabled auto-merge (squash) July 18, 2022 14:11
@shortcuts shortcuts mentioned this pull request Jul 18, 2022
Closed
@Haroenv Haroenv merged commit c46932e into master Jul 18, 2022
@Haroenv Haroenv deleted the feat/add-explain-attr branch July 18, 2022 14:52
@shortcuts shortcuts mentioned this pull request Apr 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Haroenv Haroenv Haroenv approved these changes

Assignees

@cdhawke cdhawke

Labels
TypeScript Problems related to TypeScript definitions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cdhawke @Haroenv