Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(natural-languages): adds option #1147

Merged
merged 1 commit into from
Apr 23, 2020
Merged

feat(natural-languages): adds option #1147

merged 1 commit into from
Apr 23, 2020

Conversation

nunomaduro
Copy link

This pull request adds the naturalLanguages search options.

Closes: #1107.

@nunomaduro nunomaduro added the TypeScript Problems related to TypeScript definitions label Apr 23, 2020
@nunomaduro nunomaduro self-assigned this Apr 23, 2020
Haroenv
Haroenv approved these changes Apr 23, 2020
View reviewed changes
Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good for now, in the previous version we maintained an actual list, but string is fine to prevent needless updates to the list

@nunomaduro
Copy link
Author

@Haroenv Agree - putting that level of granularity is a pain to maintain.

@nunomaduro nunomaduro merged commit a3f3c6b into master Apr 23, 2020
@nunomaduro nunomaduro deleted the feat/natural-languages branch April 23, 2020 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Haroenv Haroenv Haroenv approved these changes

@chloelbn chloelbn Awaiting requested review from chloelbn

Assignees

@nunomaduro nunomaduro

Labels
TypeScript Problems related to TypeScript definitions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(query): adds naturalLanguages parameter
2 participants
@nunomaduro @Haroenv