Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api-keys): adds ApiKeyACL type #1126

Merged
merged 3 commits into from
Apr 9, 2020
Merged

feat(api-keys): adds ApiKeyACL type #1126

merged 3 commits into from
Apr 9, 2020
+40 −4

Conversation

bodinsamuel
Copy link

  • Add ApiKeyACL type so we can strictly type the ACL's of api keys

The list can be found here:
https://www.algolia.com/doc/guides/security/api-keys/#rights-acl

@bodinsamuel
Copy link
Author

@Ant-hem @aseure nuno asked me to ping you to see if you were interested to have this type in your client's language ☺️

@nunomaduro nunomaduro requested a review from Haroenv April 9, 2020 09:55
@nunomaduro nunomaduro added the TypeScript Problems related to TypeScript definitions label Apr 9, 2020
@nunomaduro
Copy link

All tests passing.

Haroenv
Haroenv approved these changes Apr 9, 2020
View reviewed changes
Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@nunomaduro nunomaduro merged commit 25c98b8 into master Apr 9, 2020
@nunomaduro nunomaduro deleted the fix/add-apikeyacl-type branch April 9, 2020 11:21
@nunomaduro nunomaduro changed the title fix(apiKey): expose ApiKeyACL type feat(api-keys): adds ApiKeyACL type Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunomaduro nunomaduro nunomaduro approved these changes

@Haroenv Haroenv Haroenv approved these changes

Assignees

@bodinsamuel bodinsamuel

Labels
TypeScript Problems related to TypeScript definitions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bodinsamuel @nunomaduro @Haroenv