Skip to content
This repository has been archived by the owner on Jan 31, 2022. It is now read-only.

fix(Query): Accept any CharSequence #543

Merged
merged 2 commits into from
Apr 30, 2018
Merged

fix(Query): Accept any CharSequence #543

merged 2 commits into from
Apr 30, 2018

Conversation

PLNech
Copy link
Member

@PLNech PLNech commented Apr 26, 2018

Don't require to wrap a CharSequence with a String to setQuery.

@PLNech PLNech requested a review from robertmogos April 26, 2018 15:29
robertmogos
robertmogos suggested changes Apr 30, 2018
View reviewed changes
Copy link
Contributor

@robertmogos robertmogos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case Places Query should be changed too ? https://github.com/algolia/algoliasearch-client-android/blob/master/algoliasearch/src/main/java/com/algolia/search/saas/places/PlacesQuery.java

PLNech
PLNech commented Apr 30, 2018
View reviewed changes
Copy link
Member Author

@PLNech PLNech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PLNech PLNech merged commit 1ea875b into master Apr 30, 2018
@PLNech PLNech deleted the fix/queryCharSequence branch April 30, 2018 14:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@robertmogos robertmogos robertmogos approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PLNech @robertmogos