-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 588 ✨ feature invert all prices for stablecoin pairs #597
base: development
Are you sure you want to change the base?
The head ref may contain hidden characters: "issue-588-\u2728_Feature_Invert_all_prices_for_stablecoin_pairs"
Issue 588 ✨ feature invert all prices for stablecoin pairs #597
Conversation
…_for_stablecoin_pairs
…_for_stablecoin_pairs
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
… issue-588-✨_Feature_Invert_all_prices_for_stablecoin_pairs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isStable in most places should be called isInverted
stablecoins have isInverted set to true by default, otherwise false
All coins can toggle between inverted and non-inverted mode using the button @stephclarkga designed.
// } | ||
|
||
const handleChange = (e) => { | ||
if (isBuyOrder && price === '0') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this have the fixes we recently put into the place order form?
fetchCurrentAssetPrices | ||
} from 'services/algoexplorer' | ||
|
||
import { routeQueryError } from './useAlgodex' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not necessary to add this file since I ported all the hooks into /hooks. Check /hooks/http/useAlgoExplorer.js
import ServiceError from '@/components/ServiceError' | ||
import Spinner from '@/components/Spinner' | ||
import withQuery from '@/hooks/withQuery' | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above comment. We might already have this file in our repo?
} | ||
const { | ||
data: { asset } | ||
} = await axios.get(`${EXPLORER_INDEXER_API}/v2/assets/${id}?include-all=true`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this use React query instead of axios?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments
ℹ Overview
📝 Related Issues
🔐 Acceptance:
yarn test
passes