Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 588 ✨ feature invert all prices for stablecoin pairs #597

Open
wants to merge 83 commits into
base: development
Choose a base branch
from

Conversation

alchemist-bounty
Copy link
Contributor

@alchemist-bounty alchemist-bounty commented Jul 7, 2022

ℹ Overview

📝 Related Issues

🔐 Acceptance:

  • yarn test passes
  • Uses Unicode conventional commits gitmoji

@vercel
Copy link

vercel bot commented Jul 7, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
algodex-react-dev ❌ Failed (Inspect) Nov 24, 2022 at 1:08PM (UTC)

@alchemist-bounty alchemist-bounty changed the base branch from development to next3 August 5, 2022 17:09
@IYTEC IYTEC marked this pull request as ready for review September 5, 2022 20:13
Base automatically changed from next3 to development October 10, 2022 19:09
Copy link
Contributor

@atrefonas atrefonas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isStable in most places should be called isInverted

stablecoins have isInverted set to true by default, otherwise false

All coins can toggle between inverted and non-inverted mode using the button @stephclarkga designed.

// }

const handleChange = (e) => {
if (isBuyOrder && price === '0') {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this have the fixes we recently put into the place order form?

fetchCurrentAssetPrices
} from 'services/algoexplorer'

import { routeQueryError } from './useAlgodex'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not necessary to add this file since I ported all the hooks into /hooks. Check /hooks/http/useAlgoExplorer.js

import ServiceError from '@/components/ServiceError'
import Spinner from '@/components/Spinner'
import withQuery from '@/hooks/withQuery'

Copy link
Contributor

@atrefonas atrefonas Nov 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above comment. We might already have this file in our repo?

}
const {
data: { asset }
} = await axios.get(`${EXPLORER_INDEXER_API}/v2/assets/${id}?include-all=true`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this use React query instead of axios?

Copy link
Contributor

@atrefonas atrefonas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants