Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP] Budget Insight base URL configuration #126

Closed
ccoeurderoy opened this issue Nov 21, 2020 · 1 comment · Fixed by #312
Closed

[IMP] Budget Insight base URL configuration #126

ccoeurderoy opened this issue Nov 21, 2020 · 1 comment · Fixed by #312
Labels
enhancement New feature or request released

Comments

@ccoeurderoy
Copy link
Contributor

Actual behavior

If we add the Budget Insight baseUrl configuration without a / at the end, the generated URL becomes wrong.

Example:

{
  "budgetInsight": {
    "url": "https://some-sandbox.biapi.pro/2.0",
    "clientId": "id",
    "clientSecret": "secret"
  }
}

Generated URL: https://some-sandbox.biapi.pro/2.0auth/webview/fr/connect?client_id=id...

Expected behavior

The / is automatically added if it is missing at the end of the URL.
@ccoeurderoy ccoeurderoy added the enhancement New feature or request label Nov 21, 2020
amarlankri pushed a commit to amarlankri/nestjs-budget-insight-connector that referenced this issue Oct 4, 2021
Merge pull request algoan#126 from tobudim/master
7c73e9e 
feat: use cache to store GET /categories for 24h algoan#124
ccoeurderoy pushed a commit to ccoeurderoy/nestjs-budget-insight-connector that referenced this issue Dec 30, 2021
fix(budget-insight.client): parse default URL
2b66fe6 
Parse the default URL to ensure there is no extra slashes

fix algoan#126
@ccoeurderoy ccoeurderoy mentioned this issue Dec 30, 2021
Merged
ccoeurderoy pushed a commit that referenced this issue Jan 4, 2022
Merge pull request #312 from ccoeurderoy/imp/e2e-tests
e43f579 
[FEAT] E2E Tests improvements and fix #126
@algoanbot
Copy link

🎉 This issue has been resolved in version 2.11.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[FEAT] E2E Tests improvements and fix #126 ccoeurderoy/nestjs-budget-insight-connector
2 participants
@ccoeurderoy @algoanbot