Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gzip: examine Content-Length header before removing #578

Merged
merged 4 commits into from
Jan 3, 2023
Merged

gzip: examine Content-Length header before removing #578

merged 4 commits into from
Jan 3, 2023

Conversation

jsha
Copy link
Collaborator

@jsha jsha commented Jan 3, 2023

Fixes #575.

@jsha jsha force-pushed the fix-gzip-content-length branch from cd86337 to ea5acaa Compare January 3, 2023 02:49
@messense messense mentioned this pull request Jan 3, 2023
Merged
@jsha
Copy link
Collaborator Author

jsha commented Jan 3, 2023

Merging and doing the release myself because this is a pretty significant bug and I'm confident in the fix.

@jsha jsha merged commit 032bfb4 into algesten:main Jan 3, 2023
@jsha jsha deleted the fix-gzip-content-length branch January 3, 2023 04:08
algesten
algesten reviewed Jan 3, 2023
View reviewed changes
Copy link
Owner

@algesten algesten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks for quick turnaround!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@algesten algesten algesten left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reading a gzipped response hangs forever upon reaching the end of the response
2 participants
@jsha @algesten