Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new feature "tls_native_certs" #482

Closed
wants to merge 1 commit into from

Conversation

emilk
Copy link
Contributor

@emilk emilk commented Feb 7, 2022

This adds the following feature:

tls_native_certs = ["native-certs", "rustls"]

This is an alternative to the tls feature, that uses native-certs instead of webpki-roots.

Closes #478

This adds the following feature:

`tls_native_certs = ["native-certs", "rustls"]`

This is an alternative to the `tls` feature, that uses `native-certs` instead of `webpki-roots`.

Closes algesten#478
@algesten
Copy link
Owner

algesten commented Feb 7, 2022

@emilk thanks for the PR!

Since I believe the copy-left problem in #478 is resolved. The question is – why do this? :)

Is it to reduce the number of dependencies?

@emilk
Copy link
Contributor Author

emilk commented Feb 7, 2022

Well, I started on this before I realized #478 was resolved, so I thought I would finish the thought.

But yeah, it reduces dependencies for those users that want to use native-certs over webpki and webpki-roots.

Another alternative is to let users opt-in to tls and webpki-roots separately, which would require the same (minor) changes to the .rs files.

Anyway, since #478 is resolved I don't have a burning need for this, but I thought maybe others would :)

@algesten
Copy link
Owner

Let's not complicate the feature flags at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

webpki-roots is copy-left
2 participants