Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore WebAssembly support #667

Open
brandonros opened this issue Sep 30, 2023 · 15 comments
Open

Explore WebAssembly support #667

brandonros opened this issue Sep 30, 2023 · 15 comments
Labels
help wanted Extra attention is needed

Comments

@brandonros
Copy link

I don't know why I expected this to work with WebAssembly (it compiles for the wasm32-unknown-unknown target if you disable any TLS/SSL features).

But you will get to JavaScript layer and have one of what I guess is many issues (how would it know to do HTTP over fetch()?):

panicked at 'time not implemented on this platform', library/std/src/sys/wasm/../unsupported/time.rs:13:9

Stack:

Error
    at http://localhost:8080/pkg/graphql_poc.js:188:21

Which comes from

 let agent = AgentBuilder::new()
        .timeout_read(Duration::from_secs(30))
        .timeout_write(Duration::from_secs(30))
        .build();

I read you can use Chrono::Duration (which does support WASM) but AgentBuilder would need to accept non std::time::Duration?

@algesten
Copy link
Owner

Hi @brandonros! Welcome to ureq!

I have never used WebAssembly myself, so I don't actually know what would be required to make that work. The Duration here are ultimately used as socket timeouts. Those sockets are std::net::TcpStream, and I'll imagine that even if we get past the Duration problems, we will get to a dead end for the sockets. I don't know if it would be possible to solve that – blocking sockets at the bottom of the call stack?

A possible direction for a ureq 3.0, would be to isolate the HTTP request/response function into a Sans IO pattern backing library without allocations, deliberately target no_std and webassembly. Then make nice higher level wrappers for std, no_std and webasm that sits on the same core.

@jsha
Copy link
Collaborator

jsha commented Oct 6, 2023

I'm curious @brandonros, what's the use case for using ureq in WebAssembly?

If it's useful, we could probably do something where all the meaningful features are stubbed out to fetch, but we'd need some motivating use cases.

I do really like the idea of making a no_std version of ureq (with more user-friendly features stacked on top when std is present).

@algesten
Copy link
Owner

algesten commented Oct 8, 2023

@jsha i've been thinking about the no_std thing.

Here's an experiment just fleshing out what a no_std low level API could look like: https://github.com/algesten/h1-call

Design goals:

  • no_std and no alloc crate. Stack is enough
  • Sans-IO. Bring your own transport.
  • Allow flushing the buffer to the transport at any point. I.e. do not require all headers to be in the borrowed buffer at the same time.
  • Encode protocol as types, i.e. let State mean "the state the call is currently in", Version means Http/1.0 or 1.1. Method means GET/HEAD/etc...
  • Using types, constraint operations to only those that are valid. I.e. Version HTTP/1.0 cannot send a body unless the Method is POST (the others are GET/HEAD which cannot have a body).

I've fleshed out how this could look with HTTP/1.0 – but it looks pretty promising, albeit it's a type soup.

@brandonros
Copy link
Author

I'm curious @brandonros, what's the use case for using ureq in WebAssembly?

If it's useful, we could probably do something where all the meaningful features are stubbed out to fetch, but we'd need some motivating use cases.

I do really like the idea of making a no_std version of ureq (with more user-friendly features stacked on top when std is present).

You're probably right. My "vision"/idea was probably due to a lack of understanding on how things should be done in wasm land but the argument was:

write once, be able to run it backend (native Rust binary) and/or in the browser with wasm without having to add logic like if backend, use ureq, otherwise, use web-sys fetch https://github.com/search?q=repo%3Arustwasm%2Fwasm-bindgen%20fetch_with_request&type=code

@dipankardas011
Copy link

Are there any updates on this?
now the wasip2 is already out and having problems using reqwst and tokio in wasmtime. This project is the best alternative but currently not support the platform :(

@algesten
Copy link
Owner

algesten commented Jun 28, 2024

@dipankardas011 I think we need a ureq 3.0 to make this work. I'm thinking there needs to be a clean separation between connection/transport handling and the http1.1 logic.

I'm in the process of structuring the underpinnings of such a rewrite, but it's slow work. Currently my main thinking is in this branch: https://github.com/algesten/hoot

The structure I have in mind is roughly that hoot is Sans-IO http1.1 impl leaving connection/transport handling to a higher layer in the ureq crate which means that can be realized either as TcpSocket or whatever is needed in webasm.

@dipankardas011
Copy link

Np will wait

michaelkirk added a commit to michaelkirk/http-range-client that referenced this issue Aug 9, 2024
ureq used to build on wasm, but apparently it never actually worked:
algesten/ureq#667

Now it no longer builds, so I've removed it from CI.
```
error: the wasm*-unknown-unknown targets are not supported by default, you may need to enable the "js" feature. For more information see: https://docs.rs/getrandom/#webassembly-support
Error:    --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/getrandom-0.2.15/src/lib.rs:342:9
    |
342 | /         compile_error!("the wasm*-unknown-unknown targets are not supported by \
343 | |                         default, you may need to enable the \"js\" feature. \
344 | |                         For more information see: \
345 | |                         https://docs.rs/getrandom/#webassembly-support");
    | |________________________________________________________________________^

error[E0433]: failed to resolve: use of undeclared crate or module `imp`
Error:    --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/getrandom-0.2.15/src/lib.rs:398:9
    |
398 |         imp::getrandom_inner(dest)?;
    |         ^^^ use of undeclared crate or module `imp`
```
michaelkirk added a commit to michaelkirk/http-range-client that referenced this issue Aug 9, 2024
ureq used to build on wasm, but apparently it never actually worked:
algesten/ureq#667

Now it no longer builds, so I've removed it from CI.
```
error: the wasm*-unknown-unknown targets are not supported by default, you may need to enable the "js" feature. For more information see: https://docs.rs/getrandom/#webassembly-support
Error:    --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/getrandom-0.2.15/src/lib.rs:342:9
    |
342 | /         compile_error!("the wasm*-unknown-unknown targets are not supported by \
343 | |                         default, you may need to enable the \"js\" feature. \
344 | |                         For more information see: \
345 | |                         https://docs.rs/getrandom/#webassembly-support");
    | |________________________________________________________________________^

error[E0433]: failed to resolve: use of undeclared crate or module `imp`
Error:    --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/getrandom-0.2.15/src/lib.rs:398:9
    |
398 |         imp::getrandom_inner(dest)?;
    |         ^^^ use of undeclared crate or module `imp`
```
michaelkirk added a commit to michaelkirk/http-range-client that referenced this issue Aug 9, 2024
ureq used to build on wasm, but apparently it never actually worked:
algesten/ureq#667

Now it no longer builds, so I've removed it from CI.
```
error: the wasm*-unknown-unknown targets are not supported by default, you may need to enable the "js" feature. For more information see: https://docs.rs/getrandom/#webassembly-support
Error:    --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/getrandom-0.2.15/src/lib.rs:342:9
    |
342 | /         compile_error!("the wasm*-unknown-unknown targets are not supported by \
343 | |                         default, you may need to enable the \"js\" feature. \
344 | |                         For more information see: \
345 | |                         https://docs.rs/getrandom/#webassembly-support");
    | |________________________________________________________________________^

error[E0433]: failed to resolve: use of undeclared crate or module `imp`
Error:    --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/getrandom-0.2.15/src/lib.rs:398:9
    |
398 |         imp::getrandom_inner(dest)?;
    |         ^^^ use of undeclared crate or module `imp`
```
michaelkirk added a commit to michaelkirk/http-range-client that referenced this issue Aug 9, 2024
ureq used to build on wasm, but apparently it never actually worked:
algesten/ureq#667

Now it no longer builds, so I've removed it from CI.
```
error: the wasm*-unknown-unknown targets are not supported by default, you may need to enable the "js" feature. For more information see: https://docs.rs/getrandom/#webassembly-support
Error:    --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/getrandom-0.2.15/src/lib.rs:342:9
    |
342 | /         compile_error!("the wasm*-unknown-unknown targets are not supported by \
343 | |                         default, you may need to enable the \"js\" feature. \
344 | |                         For more information see: \
345 | |                         https://docs.rs/getrandom/#webassembly-support");
    | |________________________________________________________________________^

error[E0433]: failed to resolve: use of undeclared crate or module `imp`
Error:    --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/getrandom-0.2.15/src/lib.rs:398:9
    |
398 |         imp::getrandom_inner(dest)?;
    |         ^^^ use of undeclared crate or module `imp`
```
michaelkirk added a commit to michaelkirk/http-range-client that referenced this issue Aug 9, 2024
ureq used to build on wasm, but apparently it never actually worked:
algesten/ureq#667

Now it no longer builds, so I've removed it from CI.
```
error: the wasm*-unknown-unknown targets are not supported by default, you may need to enable the "js" feature. For more information see: https://docs.rs/getrandom/#webassembly-support
Error:    --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/getrandom-0.2.15/src/lib.rs:342:9
    |
342 | /         compile_error!("the wasm*-unknown-unknown targets are not supported by \
343 | |                         default, you may need to enable the \"js\" feature. \
344 | |                         For more information see: \
345 | |                         https://docs.rs/getrandom/#webassembly-support");
    | |________________________________________________________________________^

error[E0433]: failed to resolve: use of undeclared crate or module `imp`
Error:    --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/getrandom-0.2.15/src/lib.rs:398:9
    |
398 |         imp::getrandom_inner(dest)?;
    |         ^^^ use of undeclared crate or module `imp`
```
@algesten algesten changed the title WebAssembly support Explore WebAssembly support Nov 26, 2024
@algesten algesten added the help wanted Extra attention is needed label Nov 26, 2024
@algesten
Copy link
Owner

I would love for someone to try out how far away we are from running on WebAssembly. The new Transport and Resolver traits should in theory make it possible to make it work.

@brandonros
Copy link
Author

brandonros commented Nov 26, 2024

I would love for someone to try out how far away we are from running on WebAssembly. The new Transport and Resolver traits should in theory make it possible to make it work.

I just tried again with ureq = { version = "3.0.0-rc2", default-features = false } and it looks like it still does not like the std::time reference?

Should I be trying a different version? I think main also has this issue as well?

@algesten
Copy link
Owner

Hm. Well. The main branch is quite a bit ahead now. But I don't imagine this specific problem is solved.

So I guess parts of std are off limits in webasm?

@brandonros
Copy link
Author

small update

#893

I get further now, some kind of std::io error, let me trace is back

@brandonros
Copy link
Author

yeah, you'd basically need to make ureq no_std (wouldn't expect std::net::TcpStream) to work

https://github.com/search?q=repo%3Aseanmonstar%2Freqwest%20wasm&type=code

@algesten
Copy link
Owner

algesten commented Nov 27, 2024

Yeah. I think it's not miles away from no_std since I believe we can also use the alloc crate.

The default transports would be excluded and some new Transport be implemented.

@algesten
Copy link
Owner

I think I made an important stepping stone in algesten/ureq-proto#6

@algesten
Copy link
Owner

algesten commented Dec 1, 2024

Some work in #900

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants